[CORE] Fix GlutenConfig runtime modifiability#12036
Open
malinjawi wants to merge 5 commits intoapache:mainfrom
Open
[CORE] Fix GlutenConfig runtime modifiability#12036malinjawi wants to merge 5 commits intoapache:mainfrom
malinjawi wants to merge 5 commits intoapache:mainfrom
Conversation
|
Run Gluten Clickhouse CI on x86 |
1 similar comment
|
Run Gluten Clickhouse CI on x86 |
philo-he
changed the title
Contributor
|
@malinjawi thank you for the PR. Can you add one column to https://github.com/apache/gluten/blob/main/docs/velox-configuration.md and mark each config as static (⚓) or dynamic (🔄)? |
|
Run Gluten Clickhouse CI on x86 |
malinjawi
force-pushed
the
fix/11998-gluten-config-modifiable
branch
from
116ad3c to
b6c19f6
Compare
|
Run Gluten Clickhouse CI on x86 |
Contributor
|
thank you, @malinjawi. Can you fix Configuration.md as well? our config file is automatically created. Can you change the script instead? |
|
Run Gluten Clickhouse CI on x86 |
Contributor
Author
|
Thank you @FelixYBW! I updated and regenerated the docs through Verified with:
|
FelixYBW
approved these changes
May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
This PR fixes GlutenConfig runtime modifiability reporting for #11998.
GlutenConfig.get previously constructed GlutenConfig from SQLConf.get, the JVM thread-local SQLConf. Spark treats configs stored only in that static/thread-local SQLConf path as non-modifiable, so spark.conf.isModifiable("spark.gluten.*") could report false even for Gluten configs that are not static.
Main changes:
Fixes #11998.
How was this patch tested?
Focused runtime config suites:
Also checked:
Was this patch authored or co-authored using generative AI tooling?
Generated-by: IBM BOB